Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fw-6218, fw-6219, fix app logo URLs and prod app URLs #658

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Fw-6218, fw-6219, fix app logo URLs and prod app URLs #658

merged 2 commits into from
Oct 30, 2024

Conversation

sarahfirstvoices
Copy link
Contributor

Description of Changes

  • make prod URLs the default, to avoid any issues with app_env configurations
  • use the prod app logo URL formats (no '/assets')

Checklist

  • README / documentation has been updated if needed
  • PR title / commit messages contain Jira ticket number if applicable
  • Tests have been updated / created if applicable

Reviewers Should Do The Following:

  • Review the changes here
  • Pull the branch and test locally

Additional Notes

N/A

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sarahfirstvoices sarahfirstvoices merged commit 5f92aa9 into dev Oct 30, 2024
8 checks passed
@sarahfirstvoices sarahfirstvoices deleted the fw-6218-app-env branch October 30, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmcauliffe gmcauliffe gmcauliffe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarahfirstvoices @gmcauliffe